fix(UnlockableAchievementAvatar): swap t() for <Trans />
#3063
Conversation
There was a problem hiding this comment.
UnlockableAchievementAvatar is currently only used by the achievement-checklist (#3018).
The event page is handled here:
And the event achievement is handled here (this one might be real tricky):
|
There's probably not much we can do for localization on those pages until they're migrated to React. Finishing up ripping out hubs from game pages will be a big step towards migration of game pages. Once that's done, I plan on doing a phased conversion of game pages to React very similar to what happened with the home page. First, a PR just with UI components containing hardcoded values. Then, a PR to connect real data to the page. Then, subsequent PRs to stamp out all the ancillary things that come up (handling events, component edge cases, etc). |
Translators are reporting some trouble with the "from" string. This PR swaps
t('from')with a<Trans />string that has the achievement title and game title set to "sr-only". This should provide them with the context they need without causing any disruption on the page.Additionally, I implemented the TODO for showing the points in the title:
